Make OAuth2AuthorizationCodeGrantTests deterministic #2213
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leo-Fish <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
Leo-Fish
force-pushed
the
fix-flaky-hashmap
branch
from
b2876b4 to
04f8ce7
Compare
|
Thanks for the updates @Leo-Fish, however, there hasn't been any issues with the tests as the results have been consistent in CI. I don't feel these changes are necessary so I'll go ahead and close this. |
jgrandja
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
requestWhenConsentRequestThenReturnAccessTokenResponsetest is found to be non-deterministic because it relies on the iteration order of unordered Set in the test setup.This commit resolves the issue by ensuring a stable order by modifying 2 files:
The selection of a
redirect_urifrom theRegisteredClientis now deterministic by sorting the collection before selecting an element.The creation of the
OAuth2Authorizationtest data inTestOAuth2Authorizationswas updated to handle unordered collections.